Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Feed image media:content #245

Open
rorych opened this issue Aug 16, 2023 · 1 comment
Open

RSS Feed image media:content #245

rorych opened this issue Aug 16, 2023 · 1 comment

Comments

@rorych
Copy link

rorych commented Aug 16, 2023

A few years back contao changed the logic for adding images to the rss-feed:
contao/news-bundle@050e8c3

The "media:content" has been used since, instead of "enclosure".
In your override of the method generateFiles you still use the old call:
https://github.com/codefog/contao-news_categories/blob/master/src/FeedGenerator.php#L191

We noticed that on save_callback of news your method is used, but if you generate XML files via maintenance in the contao backend, the original method is used.
Leading to different xml structures each time someone saves a news or the xml is generated via daily cron.

Could you also use the new call with "media:content" parameter please?

$objItem->addEnclosure($objFile->path, $strLink, 'media:content', $arrFeed['imgSize']);

@fritzmg
Copy link
Contributor

fritzmg commented Feb 26, 2024

Is this still an issue with version 4 under Contao 5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants