Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Mixpanel current_educator on profile page #434

Closed
alexsoble opened this issue Feb 4, 2016 · 5 comments
Closed

Fix issue with Mixpanel current_educator on profile page #434

alexsoble opened this issue Feb 4, 2016 · 5 comments
Assignees
Labels

Comments

@alexsoble
Copy link
Member

JavaScript breaks on student profile page in production.

Message:

Uncaught TypeError: Cannot read property 'id' of undefined

The JS it's referencing is the Mixpanel Utils, but the error doesn't have to do with Mixpanel Utils.

The profile page dumps out inline JSON to be consumed by the front-end, which includes Educator.all.

Looks like the educator email addresses being printed detected by Cloudflare are replaced by something this:

<a class="__cf_email__" href="/cdn-cgi/l/email-protection">[email&#160;protected]</a>

Turning the Cloudflare automating email redaction off should fix the bug.

@alexsoble alexsoble added the bug label Feb 4, 2016
@alexsoble alexsoble self-assigned this Feb 4, 2016
@kevinrobinson
Copy link
Contributor

wow, that is an insane default! is this something that's just configurable in the Cloudfare UI?

@alexsoble
Copy link
Member Author

@alexsoble
Copy link
Member Author

@kevinrobinson Turned it off from the Cloudflare UI, waiting for the change to take effect.

@alexsoble
Copy link
Member Author

Cloudflare protection off. Looks like I misidentified the issue because the Mixpanel JS error is still there.

@alexsoble alexsoble changed the title Fix Cloudflare-related bug Fix issue with Mixpanel current_educator on profile page Feb 5, 2016
@alexsoble
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants