Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Browser Nav Component #1389

Open
sashamaryl opened this issue Dec 18, 2023 · 0 comments
Open

Update Browser Nav Component #1389

sashamaryl opened this issue Dec 18, 2023 · 0 comments
Assignees

Comments

@sashamaryl
Copy link
Collaborator

You will be creating the menu component for the new navigation layout, browser edition.
This should be a reusable component that extends the react-bootstrap nav components.
Use the existing navigation for a reference or build on it, refactoring as needed.

Note that the mobile navigation uses a different base component and is being built separately.

Figma for this feature: Browser Navigation: Annotations:

https://www.figma.com/file/IyRpfsVrU2pg3rysLauvQR/Navigation-V2?type=design&node-id=4356-14&mode=design

Useful project files:

  • components/layout.tsx
  • components/bootstrap.ts
  • components/Navlink.tsx

Leverage the react-bootstrap features as much as possible. See:

For styling, use bootstrap and styled components.

Create stories for components

We use storybook & chromatic to facilitate design reviews and communication, organize and document components, run UI visual tests, and for publishing our component library.
https://storybook.js.org/

@sashamaryl sashamaryl self-assigned this Feb 8, 2024
@sashamaryl sashamaryl assigned mertbagt and unassigned sashamaryl Apr 16, 2024
This was referenced Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants