Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Update #15

Closed
4 tasks done
Siddhant-K-code opened this issue Mar 11, 2021 · 24 comments · Fixed by #35
Closed
4 tasks done

Documentation Update #15

Siddhant-K-code opened this issue Mar 11, 2021 · 24 comments · Fixed by #35

Comments

@Siddhant-K-code
Copy link
Contributor

Siddhant-K-code commented Mar 11, 2021

@kaiwalyakoparkar
Copy link
Contributor

Hey @Siddhant-K-code, I would like to work on this issue. Could you please guide me?

@Siddhant-K-code
Copy link
Contributor Author

Basic of Fork, Clone & hitting a PR

It is pretty basic, you just have to add steps for a beginner-friendly ( initial steps you did to fork, clone into your system, creating a PR, upstream commands for updating forked repo with the original repo. ) with Screenshots.

Setting up the Project Locally

Yarn Commands we ran to install dependencies and running it on localhost:

yarn install

if you have to face any ERR regarding ESOCKETTIMEOUT

run:
yarn install --network-timeout 500000

after completion, run yarn start to run it on localhost:3000

you just have to document the above info with proper description and easy to understand manner

@kaiwalyakoparkar
Copy link
Contributor

does this project work with npm so that I can add that too?

@kaiwalyakoparkar
Copy link
Contributor

Please assign this issue to me. I would like to work on this.

@Siddhant-K-code
Copy link
Contributor Author

Siddhant-K-code commented Mar 11, 2021

does this project work with npm so that I can add that too?

Just Go Through the Project Once.

And, Remember this thing for all Similar Tech Stack Projects:

Check if the project has yarn.lock (installed with yarn) or package-lock.json (installed with npm)

@ritvij14
Copy link

@Siddhant-K-code I can take up the Contributing.md part, and then I will close #13 which asks for the same task. Can you assign that part to me? (You could tag me in the issue description for making that doc, so that way we know who is working on what part)

@Siddhant-K-code
Copy link
Contributor Author

@ritvij14 made the changes, will add your name beside it when you will get assigned by maintainers.

@kaiwalyakoparkar
Copy link
Contributor

Ok I am just setting up the project on my local machine. I will get back to you as soon as I finish exploring the project

@kaiwalyakoparkar
Copy link
Contributor

Hey I set up the project in my local environment. I tried both npm and yarn to run the project in localhost:3000. Both are working super fine. both yarn.lock and package-lock.json are present in the project. What should I do next?
Also,
There was a problem in package.json in react scripts:
"react-scripts": "^4.0.3", was written as "react-scripts": "4.0.3", that gave error while running in local machine

@kaiwalyakoparkar
Copy link
Contributor

Please assign this to me I am super excited to do all 4 tasks

@Siddhant-K-code
Copy link
Contributor Author

Hey I set up the project in my local environment. I tried both npm and yarn to run the project in localhost:3000. Both are working super fine. both yarn.lock and package-lock.json are present in the project. What should I do next?
Also,
There was a problem in package.json in react scripts:
"react-scripts": "^4.0.3", was written as "react-scripts": "4.0.3", that gave error while running in local machine

what was the error?

@kaiwalyakoparkar
Copy link
Contributor

kaiwalyakoparkar commented Mar 11, 2021

It was a syntax error for version of react scripts

@kaiwalyakoparkar
Copy link
Contributor

kaiwalyakoparkar commented Mar 11, 2021

I resolved that by npm install react-scripts command which also updated the pacage-lock.json file

@Siddhant-K-code
Copy link
Contributor Author

I resolved that by npm install react-scripts command which also updated the package-lock.json file

yeah, it's okay. also, did you face ESOCKETTIMEOUT err ?

@kaiwalyakoparkar
Copy link
Contributor

after that, it runs on localhost server

@kaiwalyakoparkar
Copy link
Contributor

kaiwalyakoparkar commented Mar 11, 2021

I resolved that by npm install react-scripts command which also updated the package-lock.json file

yeah, it's okay. also, did you face ESOCKETTIMEOUT err

Yes

@Siddhant-K-code
Copy link
Contributor Author

I resolved that by npm install react-scripts command which also updated the package-lock.json file

your yarn.lock should also get updated!! will create a PR for the same.

@kaiwalyakoparkar
Copy link
Contributor

I resolved that by npm install react-scripts command which also updated the package-lock.json file

yeah, it's okay. also, did you face ESOCKETTIMEOUT err ?

No

But we can add steps to resolve it in the documentation section

@kaiwalyakoparkar
Copy link
Contributor

I resolved that by npm install react-scripts command which also updated the package-lock.json file

your yarn.lock should also get updated!! will create a PR for the same.

Yes it does gets updated when we run yarn install react scripts

@kaiwalyakoparkar
Copy link
Contributor

@kaiwalyakoparkar
Copy link
Contributor

I have also added Contributing.md, Code-of-conduct.md and all you asked. Also I have made changes which fixed the previous errors

@Abhishek-kumar09
Copy link
Contributor

I have also added Contributing.md, Code-of-conduct.md and all you asked. Also I have made changes which fixed the previous errors

Please create a PR, We will discuss the rest there.

@kaiwalyakoparkar
Copy link
Contributor

ok

@AvineshTripathi
Copy link
Contributor

@Abhishek-kumar09 there are still some mistakes in the documentation which i want to correct it can i do that ??
and also guide me with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants