-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Update #15
Comments
Hey @Siddhant-K-code, I would like to work on this issue. Could you please guide me? |
Basic of Fork, Clone & hitting a PRIt is pretty basic, you just have to add steps for a beginner-friendly ( initial steps you did to fork, clone into your system, creating a PR, upstream commands for updating forked repo with the original repo. ) with Screenshots. Setting up the Project LocallyYarn Commands we ran to install dependencies and running it on localhost:
if you have to face any run: after completion, run you just have to document the above info with proper description and easy to understand manner |
does this project work with npm so that I can add that too? |
Please assign this issue to me. I would like to work on this. |
Just Go Through the Project Once. And, Remember this thing for all Similar Tech Stack Projects: Check if the project has yarn.lock (installed with yarn) or package-lock.json (installed with npm) |
@Siddhant-K-code I can take up the |
@ritvij14 made the changes, will add your name beside it when you will get assigned by maintainers. |
Ok I am just setting up the project on my local machine. I will get back to you as soon as I finish exploring the project |
Hey I set up the project in my local environment. I tried both npm and yarn to run the project in localhost:3000. Both are working super fine. both yarn.lock and package-lock.json are present in the project. What should I do next? |
Please assign this to me I am super excited to do all 4 tasks |
what was the error? |
It was a syntax error for version of react scripts |
I resolved that by npm install react-scripts command which also updated the pacage-lock.json file |
yeah, it's okay. also, did you face ESOCKETTIMEOUT err ? |
after that, it runs on localhost server |
Yes |
your |
But we can add steps to resolve it in the documentation section |
Yes it does gets updated when we run yarn install react scripts |
I have also added Contributing.md, Code-of-conduct.md and all you asked. Also I have made changes which fixed the previous errors |
Please create a PR, We will discuss the rest there. |
ok |
@Abhishek-kumar09 there are still some mistakes in the documentation which i want to correct it can i do that ?? |
The text was updated successfully, but these errors were encountered: