-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Hero for Course Detail Page #3
Comments
Can I work on this issue @Abhishek-kumar09 ? |
Yes, go on. |
@KeenWarrior @Abhishek-kumar09 I have started working on this issue. The fonts and colors has not been added to the repo yet. For now I'm using the default fonts and colors from Material UI. Also can someone ellaborate on trailer section of hero like is it a embeded video or a custom component ? |
It's an embedded video, that should play once clicked. It's a good npm package for doing it: https://www.npmjs.com/package/video-react |
@Abhishek-kumar09 Looks like the video-react project is abandoned I found a better alternative called react-player: |
Okay react-player is also good, we can play youtube videos right inside it. Does it have controls too. |
@Abhishek-kumar09 Yes it does have all controls like volume, fullscreen and play/pause. @KeenWarrior |
Create a PR and I will look to it. |
Part 1 of #2
Compoenents are required to be made with material-ui: https://material-ui.com/
The text was updated successfully, but these errors were encountered: