Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't scroll the wishlist section #37

Closed
rajatgupta24 opened this issue Mar 11, 2021 · 4 comments · Fixed by #60
Closed

Can't scroll the wishlist section #37

rajatgupta24 opened this issue Mar 11, 2021 · 4 comments · Fixed by #60
Assignees
@rajatgupta24
Labels
approved

Comments

@rajatgupta24
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.
The Wishlist section card at the end is overlaped by the bottom navbar
image

To Reproduce

Steps to reproduce the behavior:

  1. Try to scroll the wishlist section.

Environment (please complete the following information):

  • OS: ubuntu
  • Browser: firefox

Additional context

Add any other context about the problem here.
So I think we should add a little padding at the end.
@rizwan2000rm
Copy link
Contributor

Yes in layout there is just a paddingTop for navbar. Adding vertical padding something like "64px 0" fixes this issue.

@rajatgupta24
Copy link
Contributor Author

@KeenWarrior Should I make a PR

This was referenced Mar 11, 2021
Closed
Merged
@rajatgupta24
Copy link
Contributor Author

@Abhishek-kumar09 @KeenWarrior can you please review the #60

@Abhishek-kumar09
Copy link
Contributor

Fixed in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajatgupta24 rajatgupta24

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add: padding in MainLayout rajatgupta24/edu-client
Add padding in wishlist container
3 participants
@Abhishek-kumar09 @rizwan2000rm @rajatgupta24