Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navbar with static pages #89

Closed
Abhijay007 opened this issue Mar 14, 2021 · 4 comments
Closed

Add navbar with static pages #89

Abhijay007 opened this issue Mar 14, 2021 · 4 comments

Comments

@Abhijay007
Copy link
Contributor

Is your feature request related to a problem? Please describe.

currently, there is no navbar on the top of the application for the web app and android app of the project. we can add a navbar with logo and link to static pages like about us, contact, etc.

screenshots

web app
no_nav

Android through chrome inspect
mobile_nav

Describe the solution you'd like

make a new navbar/header component and use that for all pages.

@Abhijay007
Copy link
Contributor Author

@KeenWarrior @Abhishek-kumar09 can I work on this?

@Abhishek-kumar09
Copy link
Contributor

@Abhijay007 The app is more for mobile, We can add some web functionalities once the mobile 1st version is completed. I guess bottomnavbar will suffice all the requirements for mobile screens.

There will be some screens which will not be having bottomnavabar, there we would be adding topbar.

The topbar's code is already here: https://github.com/codeforcauseorg/edu-client/tree/main/src/layouts/MainLayout/TopBar

It needs only alterations adhering to the currenting application needs.

@Abhijay007
Copy link
Contributor Author

Abhijay007 commented Mar 15, 2021

@Abhijay007 The app is more for mobile, We can add some web functionalities once the mobile 1st version is completed. I guess bottomnavbar will suffice all the requirements for mobile screens.

There will be some screens which will not be having bottomnavabar, there we would be adding topbar.

The topbar's code is already here: https://github.com/codeforcauseorg/edu-client/tree/main/src/layouts/MainLayout/TopBar

It needs only alterations adhering to the currenting application needs.

ok, no problem, and thanks for letting me know about it. I will try to focus more on the mobile version from now and try to contribute more to that. you can close this issue.

@Abhishek-kumar09
Copy link
Contributor

Thanks @Abhijay007 , We will be first completing the mobile view because the motive is to create a cross platform hybrid application with capacitor, once done will be focusing on adding some extra features to make it compatible for Web versions too.

Thanks for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants