Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstructured list of Contributors #225

Closed
Suyash-Purwar opened this issue Jan 21, 2021 · 36 comments · Fixed by #531 · May be fixed by #298
Closed

Unstructured list of Contributors #225

Suyash-Purwar opened this issue Jan 21, 2021 · 36 comments · Fixed by #531 · May be fixed by #298

Comments

@Suyash-Purwar
Copy link
Contributor

I checked the code of this project and by cross-checking the list of the contributors JSON file with the displayed cards on the site, I realized that the cards are structured by the alphabetic ordering of the name of their respective JSON file. That means, say Shubham.json is displayed first then ayush.json because "capital S" is greater than "small a" in ASCII encoding.

I made a contribution to this project a day ago and I saved my JSON file with the name suyash.json. I went to the site to check my profile card. I was confused that my profile card was not mentioned even in the part where cards with the name S were starting. I scrolled further and cards with the name starting with A again started to appear. Following that, cards with the name starting with b, c, d, etc were listed. Almost at the very last of the page, I found my card.

This can cause confusion among beginners and they might even open a pull request saying "My profile card is not displayed". The number of contributors who took the pledge is about to reach 200 and I think this can happen. In fact, I was about to open an issue too.

I think cards should be arranged in alphabetical order without being case-sensitive. It should be arranged like that regardless of whether the contributor saves their JSON file with a capital letter or not. And a side note should be there on the website saying something like "Cards are arranged in the alphabetical order of contributors name" after this issue is fixed.

Alternatively, we can just take care of the upcoming contribution by adding one more point in the create_pledge.md file stating that the JSON file must be named with only the first letter being capital so that the upcoming contributions are structured. But this would leave already made contributions unstructured.

Checking whether the first letter of the JSON file is capital or not during the time of PR can be automated with integration testing which is already in place. I am not sure about this though.

Thanks for reading! 😊

@PrathameshAshra
Copy link

While rendering, do you think we can sort it out by name on " data.allContributorsJson.edges "

@Pavankalyan0105
Copy link
Contributor

Hi , I would like to work on this issue , can you suggest me the way to get started?

@Pranay178
Copy link

hlo! I would like to work on this issue can u suggest me some tips

@PrathameshAshra
Copy link

Hi , I would like to work on this issue , can you suggest me the way to get started?

Same here, still awaiting for their responses.

@Suyash-Purwar
Copy link
Contributor Author

I think you guys should start and make a pull request.

@tejasjadhav1
Copy link

Hi

@tejasjadhav1
Copy link

How can i solve this issue

@ghost
Copy link

ghost commented Feb 5, 2021

Hi, I am new here, and would like to work on the issue.
Suggest me the ways

@viki4545
Copy link
Contributor

viki4545 commented Feb 5, 2021

Hi, i would like to work on this issue, can you suggest me how to get started?

@ghost
Copy link

ghost commented Feb 10, 2021

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

@KamalSinghKhanna
Copy link

Hi, I want to work on this issue, can you suggest me ways to get started?

@salmanprottoy
Copy link
Contributor

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

2 similar comments
@PrincePandey1
Copy link

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

@Parth-Shete
Copy link

Hi, I would like to work on this issue, can you suggest me ways to get started with this?

@dazzleprogrammer
Copy link
Contributor

Hey ! I would like to work on this issue.

@SuryanshShahi
Copy link
Contributor

Hi , I would like to work on this issue , can you suggest me the way to get started?

@balarka135
Copy link

I would like to work on this issue

@SarthakSrivastav
Copy link

Hi , I would like to work on this issue , can you suggest me the way to get started?

@SarthakSrivastav
Copy link

Hi, @Shivam-45
I follow this video and I'm trying to make my first full request which I successfully done and push it on github. Now I am waiting to merge my code from your side.
Please merge it ASAP if all are good so that I feel more confident that yessss I did it.
Thankyou.

@ujjwal-sharma221
Copy link

Just a new github user passing by

@hassanrahim26
Copy link

Hi, I am Hassan. I would like to work on this issue, can you suggest ways to get started?

@Ritikkumar992
Copy link

I want to work on this project can you help me

@starrohan999
Copy link

Hii I would like to work on the Demo issue, can you suggest to me ways to get started?

@nitinya9av
Copy link

Hi, I would like to work on this issue, can you suggest me the way to get started?

1 similar comment
@Nitesh639
Copy link

Hi, I would like to work on this issue, can you suggest me the way to get started?

@mkhulbe5
Copy link

Hi,i would like to work and to started of with open source thing, anyone here to guide me up?

1 similar comment
@Ritikkumar992
Copy link

Hi,i would like to work and to started of with open source thing, anyone here to guide me up?

@Sajal0208
Copy link

HEy I would like to work on this issue

@ARSHADKHAN615
Copy link

kiya bolte publllic 😎😎

@HarshKumarSingh07
Copy link

Hey, I am beginner. Kindly guide me through the way forward.

@ARSHADKHAN615
Copy link

How can I help you brother

@gaurav-uk2001
Copy link

hey, i would like to work in this issue

@ZohebMOPO
Copy link

Hey Everyone. This is my first time contributing to open source.

@Aman-mnnit
Copy link

Hi i would like to fix this issue,can you please suggest me how to start?

@classickartik
Copy link

Hi , I would like to work on this issue , can you suggest me the way to get started?

@simran-kamboj
Copy link

Hi, I would like to work on this issue , can u suggest me the way to get started?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet