Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tachyons for styling #45

Closed
3 tasks done
afisher opened this issue Aug 27, 2017 · 4 comments
Closed
3 tasks done

Use Tachyons for styling #45

afisher opened this issue Aug 27, 2017 · 4 comments
Assignees
Milestone

Comments

@afisher
Copy link
Collaborator

afisher commented Aug 27, 2017

I would like to propose switching our styling over to http://tachyons.io/
I have been using Tachyons for some personal stuff, and as someone who hates writing CSS, it has been a lifesaver. I believe that switching will allow us to keep our styling simple, easy to update, and help us remain consistent with multiple contributors.

To complete this, you will need to:

  • Include tachyons.css in our index.html
  • Remove the existing CSS (bartercheckout.css)
  • Replace all class names in the React component render() functions with tachyons class names
@razzlepdx razzlepdx self-assigned this Sep 16, 2017
@razzlepdx
Copy link
Collaborator

I'm going to remove myself from this issue in case someone wants to tackle it this weekend at the group meetup.

@razzlepdx razzlepdx removed their assignment Oct 26, 2017
@jarrighi
Copy link
Collaborator

jarrighi commented Nov 8, 2017

@afisher Could you clarify what benefit tachyons has over bootstrap? I'm not against it, I'm just not understanding the problem it solves from the bit of reading I've done. We're not really using the full potential of bootstrap now, and I'd rather stick to libraries and frameworks that are widely used as long as they work for us.

@afisher
Copy link
Collaborator Author

afisher commented Nov 8, 2017

I've personally found tachyon's easier and simpler to use. The kind of "customization" we need to do to the UI isn't a ton, but we already have a fair amount of CSS and that is just going to keep growing and being a thing we have to maintain. I believe that if we switch to tachyons, we actually won't need to write any CSS at all.

It's also much, much more lightweight than bootstap, which is pretty overkill for our needs.

@jarrighi
Copy link
Collaborator

Okay cool, I'm still pretty skeptical, but I may just be set in my bootstrappy ways. I want to do some work on the UI, so I'll take this one.

@jarrighi jarrighi self-assigned this Nov 27, 2017
@jarrighi jarrighi added this to the mvp milestone Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants