-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process.on('uncaughtException') no longer catches all exception in express #16
Comments
Hi @than-speedline, could you provide a minimum reproducible example? |
|
Sorry, i meant uncaughtException. I'll try to create a simple test case, please give me a sec. |
Hi, i manage to get an example working. Here is the link to the gist. |
Just an update, I realized that Lambda doesn't support uncaughtException properly. So i guess this is not the problem with this library. This issue should probably be closed. |
Thanks for the update! |
@Tony-Donghua-Han Seems you unfortunately deleted the |
Hi, after using aws-serverless-express, i noticed that node process.on('uncaughtException') of our previous express application doesn't catch all exception from async callbacks anymore. Is there another way to catch all exception that cause the server to crash?
This happens when we use the "request" model and an uncaught exception happens in the callback of an request.
The text was updated successfully, but these errors were encountered: