Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EclipseJavaCompiler does not respect CompilerConfiguration.sourceFiles, leading to FilerException: Source file already created on mvn compile without clean when e.g. mapstruct is involved #232

Closed
famod opened this issue Jul 14, 2022 · 1 comment · Fixed by #233
Closed

EclipseJavaCompiler does not respect CompilerConfiguration.sourceFiles, leading to FilerException: Source file already created on mvn compile without clean when e.g. mapstruct is involved #232

famod opened this issue Jul 14, 2022 · 1 comment · Fixed by #233

Comments

@famod
Copy link
Contributor

famod commented Jul 14, 2022

Details: #231 (comment)

This aims at doing the first step; making EclipseJavaCompiler use AbstractCompiler.getSourceFiles(CompilerConfiguration) instead of it's own (faulty) logic.

The second step of figuring out what to do (also for javac!) when no explicit sourceFiles are present is not part of this issue.
@famod famod mentioned this issue Jul 14, 2022
Merged
@famod
Copy link
Contributor Author

famod commented Jul 15, 2022

Thanks @olamy! It would be nice to have a release with this (and the updated ECJ dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect CompilerConfiguration.sourceFiles in EclipseJavaCompiler famod/plexus-compiler
1 participant
@famod