Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag releases with semver #15

Closed
codehearts opened this issue Jul 24, 2019 · 2 comments · Fixed by #36
Closed

Tag releases with semver #15

codehearts opened this issue Jul 24, 2019 · 2 comments · Fixed by #36
Milestone
v1.0.0

Comments

@codehearts
Copy link
Owner

As a dependency for developers looking to test their scripts, it's wild for shpy to not be versioned. Tag some node as 1.0.0 and we can go from there
@codehearts codehearts mentioned this issue Jul 24, 2019
Closed
@codehearts codehearts added this to the v1.0.0 milestone Aug 25, 2019
@codehearts
Copy link
Owner Author

The contribution guidelines should specify that we use semver, and what sorts of changes constitute a version bump. They should also mention to only tag master, and that tagging with semver will automatically create a tagged Docker image

@codehearts
Copy link
Owner Author

Shpy should also provide a documented SHPY_VERSION variable, which may be handy when diagnosing bugs or other cases

@codehearts codehearts mentioned this issue Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Version shpy codehearts/shpy
1 participant
@codehearts