Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing broken in travis-ci #1003

Closed
jim-parry opened this issue Apr 26, 2018 · 6 comments
Closed

Unit testing broken in travis-ci #1003

jim-parry opened this issue Apr 26, 2018 · 6 comments

Comments

@jim-parry
Copy link
Contributor

Several things have happened over the last 8 PR merges or so, breaking travis-ci. The unit tests are failing, but travis-ci is reporting "success".

PR 981 passed (1836 tests)
PR 984 LoggerTest failed (1 of 1837 tests) - not changed in this PR
PR 986 no change
PR 990 no change, except for more Javascript in front of tests
PR 993 travis-ci "breaks"

  • "yarn" command not found
  • 1.5 pages of "failed to fetch" errors"
  • 8 failures on row two of tests
  • "reset($vars) and more javascript on row after test 1098 ... system/Common.php:965
  • phpunit exits without completing, reports success
  • unclear if LoggerTest still fails or even runs
    PR 995 travis-ci "breaks" more
  • half page of gpg errors
  • 10 failures now, on rows 2 & 3 of tests
  • phpunit exits without completing, tracis reports success
    PR 996 no change
  • still broken, same errors but success reported
    PR 998 no change
@lonnieezell
Copy link
Member

I think it's just that my exceptions branch is still throwing lots of errors. Develop branch seems fine.

@jim-parry
Copy link
Contributor Author

Hmmm - PR 993, where things first started to go south, seems to be the develop branch to me. :-/
#993 ... and follow the link to the travis-ci details.

@lonnieezell
Copy link
Member

Oh, I see what you mean now. Well - I just got all of the tests for my exceptions branch working, so I'll be merging that here shortly and we'll see what it looks like after that.

I know I fixed a stray dd() call a couple of nights ago. Thought I did it in the develop branch, but guess not.

@lonnieezell
Copy link
Member

Yup. that seemed to fix everything. Closing this.

@jim-parry
Copy link
Contributor Author

jim-parry commented Apr 27, 2018

Er, it didn't fix everything.
I get ...
PHP Fatal error: Cannot declare class CodeIgniter\Exceptions\EmergencyError, because the name is already in use in /pub7/htdocs/CodeIgniter4/system/Exceptions/Error.php on line 9
and I see that system/Exceptions/Error.php declares the class EmergencyError.
Yes, this is in the current develop branch of the repo :(
Changing the class name to simply Error resolves the above, but I don't know what else is planned.

@lonnieezell
Copy link
Member

Strange that doesn't show up locally or on Travis. :(

Renaming that class to simply Error is fine, and as it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants