New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insert() doesn't return boolean but CodeIgniter\Database\MySQLi\Result #1365

Closed

bvrignaud opened this issue Oct 27, 2018 · 0 comments

Contributor

bvrignaud commented Oct 27, 2018 •

edited

Loading

The insert function (in BaseBuilder.php) doesn't return boolean value as documention and php code doc said, but :

on success : return CodeIgniter\Database\MySQLi\Result
on error : exception

I think, it's more a documention error ?

What do you think ?
I can send you a PR if you want.

CodeIgniter 4 version
develop branch up to date

Affected module(s)
BaseBuilder.php / documention

Context

Web server : Apache/2.4.10 (Debian), php 7.1 on docker
mariadb on lmde 3

jim-parry mentioned this issue

Fix phpdocs for BaseBuilder #1466

Merged

jim-parry closed this as completed in #1466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment