Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar download bug #2117

Closed
MGatner opened this issue Aug 1, 2019 · 0 comments
Closed

Toolbar download bug #2117

MGatner opened this issue Aug 1, 2019 · 0 comments

Comments

@MGatner
Copy link
Member

MGatner commented Aug 1, 2019

Describe the bug
Issuing a DownloadResponse with the DebugToolbar causes a type error when the toolbar attempts to pass total_execution which hasn't been calculated because of the direct Response return.

CodeIgniter 4 version
Latest develop

Affected module(s)
DownloadResponse, DebugToolbar, ToolbarFilter

Expected behavior, and steps to reproduce if appropriate
In a controller with DebugToolbar enabled call return $this->response->download($filename).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants