Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devstarter $salt #2156

Closed
MGatner opened this issue Aug 20, 2019 · 5 comments
Closed

Devstarter $salt #2156

MGatner opened this issue Aug 20, 2019 · 5 comments
Labels
waiting for info Issues or pull requests that need further clarification from the author

Comments

@MGatner
Copy link
Member

MGatner commented Aug 20, 2019

I'm not sure what failed in the deployment to devstarter (there have been a few of these issues reported) but it still has an old version of app/Config/App.php that includes $salt

@jim-parry
Copy link
Contributor

The devstarter was a snapshot of the repo some 4-7 months ago, and it looks like it could use refreshing. I will do that this afternoon.

@jim-parry
Copy link
Contributor

Just refreshed the devstarter base files. Does the repo work better for you now, after synching yours separate from composer update?

@jim-parry jim-parry added the waiting for info Issues or pull requests that need further clarification from the author label Sep 1, 2019
@MGatner
Copy link
Member Author

MGatner commented Sep 3, 2019

This looks much better! I'm unfamiliar with the back-end deployment process but it would be great to have some automated sync from https://github.com/codeigniter4/CodeIgniter4/tree/develop to appstarter's and devstarter's "user files" (app/, spark, etc - anything not updated by Composer).

@jim-parry
Copy link
Contributor

The appstarter is part of the release process, so updated in synch with the framework automatically. If there are flaws in the process, that needs to be fixed in the admin release scripts.

The devstarter is not part of any update or automatic process - it isn't tied to any release, but is instead meant to be "in progress". Maybe the repo needs to be rethought, and somehow have closer ties to the main one. The repo was created to helo my students work on merged but unreleased code, and it's serendipitous that it is useful for addin developers :-/

Maybe I'll start a thread for this on the forum, and see what we can come up with!

@MGatner
Copy link
Member Author

MGatner commented Sep 3, 2019

Sounds good. Yeah I love the devstarter but it would be great if there were some way to do it so the user portions came from this repo's develop branch yet still had its own composer.json to handle the "guts". I'll think on it too - right now I'm using a janky script that installs the devstarter then clones develop from the main repo and replaces the files explicitly.
https://github.com/tattersoftware/lighter/blob/develop/lighter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Development

No branches or pull requests

2 participants