Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated assertArraySubset in PHPUnit8 used in FeatureResponse::assertJSONFragment #3562

Closed
paulbalandan opened this issue Aug 29, 2020 · 1 comment · Fixed by #3577
Closed

Deprecated assertArraySubset in PHPUnit8 used in FeatureResponse::assertJSONFragment #3562

paulbalandan opened this issue Aug 29, 2020 · 1 comment · Fixed by #3577
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@paulbalandan
Copy link
Member

This is meant to be addressed in v4.1 where hopefully after bumping PHP version requirement we'll also bump dependencies' version, like phpunit to v9.

FeatureResponse::assertJSONFragment is using the deprecated assertArraySubset method.
@paulbalandan paulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 29, 2020
@MGatner
Copy link
Member

MGatner commented Aug 30, 2020

Definitely that will be the time to make the change. I'm sure this can be addressed sooner - thanks for making the note on it.

@paulbalandan paulbalandan mentioned this issue Aug 31, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes deprecation of assertArraySubset
2 participants
@MGatner @paulbalandan