Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: \Config\Services::image()->flatten() #3728

Closed
cowboyjs opened this issue Oct 6, 2020 · 0 comments · Fixed by #3737
Closed

Bug: \Config\Services::image()->flatten() #3728

cowboyjs opened this issue Oct 6, 2020 · 0 comments · Fixed by #3737
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@cowboyjs
Copy link

cowboyjs commented Oct 6, 2020

CodeIgniter 4 version
CodeIgniter 4.0.4

system/Images/Handlers/BaseHandler.php 407 line

return $ this-> _flatten();
Maybe this part needs to be changed as follows?

return $ this-> _flatten($ red, $ green, $ blue);
@cowboyjs cowboyjs added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 6, 2020
@michalsn michalsn mentioned this issue Oct 7, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix _flatten() call in BaseHandler for Image class michalsn/CodeIgniter4
1 participant
@cowboyjs