New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database Connection setDatabase() and getVersion() methods #68

Closed

mwhitneysdsu opened this issue May 6, 2016 · 1 comment

Milestone

Contributor

mwhitneysdsu commented May 6, 2016

In the BaseConnection and MySQLi\Connection, setDatabase() and getVersion() are missing their access/visibility keywords:

abstract function setDatabase(string $databaseName);
abstract function getVersion();

function setDatabase(string $databaseName)
{
}

function getVersion()
{
}

I would assume they should be public, but I figured I'd call it out just in case.

The text was updated successfully, but these errors were encountered:

Member

lonnieezell commented May 6, 2016

Correct. Those were the results of simply porting the functions over.

lonnieezell added this to the Phase 1 milestone

mwhitneysdsu closed this as completed in

a4c36a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment