Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [OCI8] Bug: Argument #1 ($value) must be of type ?int, string given #8811

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: [OCI8] Bug: Argument #1 ($value) must be of type ?int, string given #8811

wants to merge 1 commit into from

Conversation

allyblaise
Copy link

@allyblaise allyblaise commented Apr 19, 2024 •
edited by kenjis

Fixes #8809

cast $this->port to string on ctype_digit of OCI8 Connection

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Apr 19, 2024 •
edited

Thank you for sending this PR.

First of all, you must sign all your git commits. We never accept PRs without GPG signing.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/signing.md

Next, please fix failed checks in GitHub Actions.

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#contributions

@kenjis kenjis changed the title fix issue #8809: Bug: Argument #1 () must be of type ?int, string given fix: [OCI8] Bug: Argument #1 () must be of type ?int, string given Apr 19, 2024
@kenjis kenjis added tests needed Pull requests that need tests GPG-Signing needed Pull requests that need GPG-Signing database Issues or pull requests that affect the database layer labels Apr 20, 2024
@paulbalandan paulbalandan changed the title fix: [OCI8] Bug: Argument #1 () must be of type ?int, string given fix: [OCI8] Bug: Argument #1 ($value) must be of type ?int, string given Apr 22, 2024
@paulbalandan
Copy link
Member

I don't think this is the fix for the referenced issue. The issue is on BaseBuilder::limit() called on Model which complains of string value. Then, this fix forces a string port. So I think this is a fix to a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer GPG-Signing needed Pull requests that need GPG-Signing tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [OCI8] Argument #1 ($value) must be of type ?int, string given
3 participants
@allyblaise @kenjis @paulbalandan