Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace for test case classes #17

Closed
kenjis opened this issue Mar 12, 2016 · 3 comments
Closed

Namespace for test case classes #17

kenjis opened this issue Mar 12, 2016 · 3 comments

Comments

@kenjis
Copy link
Member

kenjis commented Mar 12, 2016

The current test case classes has no namespace.
I think it is better they have also namespaces. It avoids class name collisions.

And in my opinion, it is the best that a test case class has the same namespace as the class under test.
In that case, we can write class names in test code with the same style as the class under test.

What do you think?

@lonnieezell
Copy link
Member

I have no problem with those changes. Sounds like good organization. As long as it works without changing the autoloaders, I'm good. I look forward to the pull request.

@kenjis
Copy link
Member Author

kenjis commented Mar 15, 2016

I sent PR: #19

@lonnieezell
Copy link
Member

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants