Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images with some characters in the URL are not imported #928

Closed
tio-trom opened this issue Apr 15, 2024 · 1 comment · Fixed by #930 or #933
Closed

Images with some characters in the URL are not imported #928

tio-trom opened this issue Apr 15, 2024 · 1 comment · Fixed by #930 or #933
Assignees
@preda-bogdan
Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@tio-trom
Copy link

Description

If the URL contains some characters like the bellow ones:

321499511-779dbb66-274e-48cb-b20f-9cb6c75d057e

Example: https://s3-eu-central-1.amazonaws.com/cartoons-s3/styles/product_detail_image/s3/%C3%A7%C3%B6p.jpg?itok=ZYU_ihPB

Step-by-step reproduction instructions

As explained above.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No
@tio-trom tio-trom added the bug This label could be used to identify issues that are caused by a defect in the product. label Apr 15, 2024
@vytisbulkevicius vytisbulkevicius added the Priority-Medium Expected resolution time - up to 1 month. label Apr 15, 2024
@preda-bogdan preda-bogdan added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Apr 16, 2024
preda-bogdan added a commit that referenced this issue Apr 17, 2024
@preda-bogdan
fix: image import forn non-ASCII URLs
0f8d13c 
References: #928
@preda-bogdan preda-bogdan mentioned this issue Apr 17, 2024
Merged
6 tasks
@vytisbulkevicius vytisbulkevicius linked a pull request May 30, 2024 that will close this issue
Release #933
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.4.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preda-bogdan preda-bogdan

Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/image import non ascii Codeinwp/feedzy-rss-feeds
Release Codeinwp/feedzy-rss-feeds
4 participants
@preda-bogdan @vytisbulkevicius @tio-trom @pirate-bot