Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new CoffeeScript mode for CodeMirror #3450

Closed
huaoguo opened this issue Aug 12, 2015 · 4 comments
Closed

A new CoffeeScript mode for CodeMirror #3450

huaoguo opened this issue Aug 12, 2015 · 4 comments

Comments

@huaoguo
Copy link

huaoguo commented Aug 12, 2015

I made a new CoffeeScript mode for CodeMirror https://github.com/huaoguo/codemirror-coffee-script. Hope it would be useful.

Screencasts

monokai

material

@marijnh
Copy link
Member

marijnh commented Aug 12, 2015

Hi. Could you tell me how this improves on the existing CoffeeScript mode? And is your intent to have this become part of the main distribution?

@huaoguo
Copy link
Author

huaoguo commented Aug 12, 2015

@marijnh
This mode implements all the CoffeeScript language specification, like:

  • and、is、or... keywords will be highlight
  • Class(capital word) will be highlight
  • method def will be highlight
  • properties will be highlight
  • module、exports、require (commonjs) will be highlight
  • and so on...

It make the highlight more comprehensive.

Yes, I want let it become part of the main distribution.

@marijnh
Copy link
Member

marijnh commented Aug 20, 2015

I've taken a closer look, but your mode doesn't do any indentation, which seems a regression. Have you considered simply modifying the old mode to fix its shortcomings? I've pushed 89c8c3d, which highlights properties as properties. I noticed that operators like and and is are already highlighted as operators (choose a different theme if you want a different color for them).

@marijnh
Copy link
Member

marijnh commented Sep 2, 2015

Closing until further comments.

@marijnh marijnh closed this as completed Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants