Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fails on IE78 #697

Closed
peterkroon opened this issue Aug 4, 2012 · 8 comments
Closed

[test] fails on IE78 #697

peterkroon opened this issue Aug 4, 2012 · 8 comments

Comments

@peterkroon
Copy link
Contributor

[IE7]
measureEndOfLine: [object Error]
scrollVerticallyAndHorizontally: assertion failed (bottom line visible)
moveV stuck: {line:0,ch:0} != {line:0,ch:26} 3 failures

[IE8]
measureEndOfLine:
TypeError: De eigenschap of methode getElementsByClassName wordt niet ondersteund door dit object
scrollVerticallyAndHorizontally: assertion failed (bottom line visible)
moveV stuck:
TypeError: Kan de waarde van de eigenschap offsetHeight niet ophalen: het object is null of niet gedefinieerd 3 failures

@marijnh
Copy link
Member

marijnh commented Aug 6, 2012

Indeed. Fixed in dad0bd1 . I hope to set up a bunch of headless tests at some point, but I can't find a drop-in package for that, so it'll be a bunch of sysadmin work. Man I hate sysadmin work.

@marijnh marijnh closed this as completed Aug 6, 2012
@peterkroon
Copy link
Contributor Author

Man I hate sysadmin work.

Haha...:-)

Sorry to tell you, but IE7 is not fixed.

measureEndOfLine: assertion failed (not at right)
moveV stuck: {line:0,ch:0} != {line:0,ch:26}
2 failures

@marijnh marijnh reopened this Aug 6, 2012
@marijnh
Copy link
Member

marijnh commented Aug 6, 2012

Oh, I see, my brain somehow refused to see the part about IE7, and I only tested IE8.

I could fix one of the IE7 issues, the other three are related, and something that I'm not sure I want to spend much more time on (it's a corner case bug, related to the various problems we saw with the last character on a wrapped line).

Maybe it's time to introduce the concept of expected failures to the test suite.

@marijnh
Copy link
Member

marijnh commented Aug 9, 2012

Done in 264ccbd and df21300

@marijnh marijnh closed this as completed Aug 9, 2012
@peterkroon
Copy link
Contributor Author

Thanks!

@peterkroon
Copy link
Contributor Author

IE7

verticalScroll: 110 != 100
wordMovementCommands: {line:1,ch:8} != {line:1,ch:9}
2 failures

IE8

wordMovementCommands: {line:1,ch:8} != {line:1,ch:9}
1 failure

@peterkroon
Copy link
Contributor Author

Opera W732

wordMovementCommands: {line:1,ch:8} != {line:1,ch:9}
1 failure

@peterkroon
Copy link
Contributor Author

Firefox 15 BETA

wordMovementCommands: {line:1,ch:8} != {line:1,ch:9}
1 failure

marijnh added a commit that referenced this issue Aug 10, 2012
Makes tests pass on IE, FF, and Opera again.

Apparently, toUpperCase isn't all that standards, and ß.toUpperCase()
produces SS on Webkit, ß on other browsers.

Also worked around some crumminess in the way IE7 reports clientWidth.

Issue #697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants