Workaround for #3261 Selection problem in IE11, when leaving an iframe while selecting #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2015 13:11
…le selecting Make sure, that we're not starting a second selection.
…rame while selecting" This reverts commit 8d76211.
…le selecting Make sure, that we're not starting a second selection.
| // #3261: make sure, that we're not starting a second selection | ||
| if (cm.state.selectingText) { | ||
| cm.state.selectingText(e); | ||
| return; |
There was a problem hiding this comment.
Why not check this in onMouseDown? That'd also save the extra condition above (when deciding between a drag and a select).
|
Merged in slightly changed form as b22783d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the mouse leaves the iframe during text selection, the MouseEvents are no longer sent to Codemirror. If the user lets go of the left mouse button, CodeMirror does not know that the text selection has stopped.
Chrome and Firefox allow to check the states of the mouse buttons on mouse move. Codemirror does this and stops the text selection. This does not work on any version of IE.
Workaround for IE: Check on each left click, if text is currently being selected. If yes, the selection is finished. This is not perfect, but prevents Codemirror from starting a second text selection and going crazy.