Handle <constructor> tags in htmlmixed mode (fixes mozilla bug 1214663) #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,10 +91,11 @@ | |||
| function html(stream, state) { | |||
| var tagName = state.htmlState.tagName; | |||
| var tagInfo = tagName && tags[tagName.toLowerCase()]; | |||
| var isTagInfoArray = Object.prototype.toString.call(tagInfo) === "[object Array]"; | |||
There was a problem hiding this comment.
I also considered using Array.isArray, but IE8 doesn't support that. I took this from the polyfill at https://developer.mozilla.org/ro/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray.
|
Woops how shoddy. I've pushed an alternative patch that solves this by checking out whether the property exists in the object itself, rather than checking for an array. That seems more idiomatic and robust. |
|
Alright, thanks. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1214663. The HTML mixed syntax mode is breaking the editor when encountering a
<constructor>tag, so instead of checking that tagInfo exists, we need to make sure it's actually an array before continuing into findMatchingMode.You can see the problem if you update the modes index.html demo to include this tag: