"Enter" key behavior is strange with IME on Chrome

[azu]

I've enter following text with Google IME(Input method) on https://codemirror.net/6/ and I get wrong <NewLine> result.

NIHONGO<Space><Enter>

📝 Press <Space><Enter> to select the highlighted candidate and inputed 日本語 as results(日本語 === NIHONGO)

Expected result:

日本語|<Cursor is here>

Actual result:

<NewLine>
日本語|<Cursor is here>

GIF:

Keyboard event results on https://w3c.github.io/uievents/tools/key-event-viewer.html:

• Chrome: Keyboard Event Viewer.pdf
• Firefox: firefox-Keyboard Event Viewer.pdf

Env

• OS: macOS Catalina
• Browser: Google Chrome 83.0.4103.61

I've tested Firefox 76.0.1 and It works as expected.

Maybe, Keyboard event(CompositionEvent) handling is something wrong?

[azu]

I've also tested on "@codemirror/next": "^0.6.0" without exntensions.

import { EditorView } from "@codemirror/next/view";
import { EditorState } from "@codemirror/next/state";

new EditorView({
    state: EditorState.create({
        doc: "",
        extensions: []
    })
});

In this case, Cursor is moved to first of the line after select the highlighted candidate.

Expected result:

日本語|<Cursor is here>

Actual result:

|<Cursor is here>日本語

GIF:

[marijnh]

Attached patch should help with this.

[azu]

Is this issue resolved in 0.7.0?

I still met same issue on https://codemirror.net/6/ and "@codemirror/next": "^0.7.0"

Edit: I've noticed that extensions: [] work fine at 0.7.0.

It seem that defaultKeymap cause this issue again.

new EditorView({
    state: EditorState.create({
        doc: "",
        extensions: [
            keymap([
                ...defaultKeymap
            ])
        ]
    })
});

Maybe, insertNewlineAndIndent command has an issue.

[marijnh]

Oh, too bad. My patch fixed the issue in Chrome Linux (where it did originally occur too), bit it's entirely possible that macOS IME works differently. I'll test on a Mac soon.

[marijnh]

Could you try again with 0.7.1?

[azu]

Thanks.
I've confirm that 0.7.1 work fine!

[marijnh]

Wonderful!