-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sluggish scrolling on iOS (and Android) #2936
Comments
Since you're working in the Xcode simulator, I presume you have access to the source. See if disabling the gesture recognizer improves the performance for you. You can do that by commenting out the contents of the following method in CN1TapGestureRecognizer.m
|
@shannah this has no effect unfortunately. But I noticed the scrolling gets less sluggish the more I scroll down (when the background image is completely covered) |
What happens when you remove/omit the image altogether? |
@shannah that isn't the cause either as it also happens without the image. I'm now kinda reconstructing that UI content. That was something I wanted to avoid in the first place as the UI is a bit complex and mostly built by the CN1 Designer, but it seems inevitable to fix this issue. Maybe the |
@shannah |
I was too focussed on the iOS side and trying to fix this issue so that I just recently realized that on the android side there is also a worse scrolling experience compared to our older builds. It is not as intense as it is in iOS but it is quite noticable. So I assume this is not only a iOS thing but rather something which is affected by the core CN1 implementation. |
Can you post a minimal test case that will demonstrate this issue? |
@shannah I prepared one here: As there is nesting of |
@shannah there is also another issue you may notice. The top slider kinda gets stretched vertically while scrolling even though the size should stay fix. |
That test case scrolls smoothly on my iPhone X. |
This issue was resolved by disabling enableLayoutOnPaint. d4ddcad |
this issue began to happen around the time when I submitted #2928. Since I noticed that this is happening on any iOS version I decided to open a separate issue. Thus the fix of #2928 just had a quite small effect in fixing this. I still try to figure out what the cause is and try to code a sample for reproduction. For the meantime, I do know that under theses circumstances you might not be able to tackle this but nevertheless hopefully you might have a clue about the cause by viewing the demo below..
CN1 simulator on the left with smooth scrolling, iOS simulator on the right:
Note: it's also working properly on Android. Furthermore, before the mentioned time of occurence it worked properly on iOS as well which I still can confirm on iOS devices where the older version of this app (also means older version of CN1) is still installed.
The text was updated successfully, but these errors were encountered: