Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self creating dependencies #34

Closed
5 tasks done
bastianschwarz opened this issue Sep 20, 2020 · 1 comment · Fixed by #38
Closed
5 tasks done

Self creating dependencies #34

bastianschwarz opened this issue Sep 20, 2020 · 1 comment · Fixed by #38
Assignees

Comments

@bastianschwarz
Copy link
Member

bastianschwarz commented Sep 20, 2020

There is a feature request to automatically add dependencies. Although I'm not a huge fan of it I understand the wish to only add the "top level providers" and have the dependencies added automatically.

  • Create a new "RecursiveDependencies" collection
  • Add the dependencies recurisvley before adding the provider
  • Check if the dependency is already added (use a diff) before the recursion
  • Create a provider factory interface to create the provider classes from the dependency class names to have at least some flexibility in how the dependencies are created
  • Create a "SimpleNew" factory implementation and set it in the "RecursiveDependencies" constructor as default
@bastianschwarz
Copy link
Member Author

@Suranex Delivered as ordered ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant