Validation warning for using non-public selector 'instance'

[vvasanth86]

We were trying to submit an app yesterday that had HockeySDK (2.2.2), but the app failed validation with the following warning:

"The app references non-public selectors in Payload/.app/: instance"

After a quick search, we found that HockeySDK was referring to 'instance' in legacy JMC connect code. Can you guys fix this?

[ashtom]

The call to "instance" is surrounded by #ifdef JMC_LEGACY, see here:
https://github.com/codenauts/HockeySDK-iOS/blob/develop/Classes/CNSHockeyManager.m#L69

This macro is not included in the SDK, so the code gets never executed. Is that macro set somewhere in your code?

[vvasanth86]

No, I havn't defined that macro. I'm using cocoapods to define the dependencies, but I dont think that should make any difference.

[ashtom]

Hm, maybe cocoapods still pulls an older version. Can you compare the code in your copy of CNSHockeyManager.m, method jmcInstance, with this:
https://github.com/codenauts/HockeySDK-iOS/blob/develop/Classes/CNSHockeyManager.m#L64

Do you use JMC at all? If not, a simple fix would be to remove all lines from this method and always return nil.

[vvasanth86]

@ashtom Looks like cocoapods does indeed pull from an older version. I dont see the JMC_ENABLED macro in my version.

I guess pods spec needs to be updated. Would you mind creating a new tag that we can point to in the pod spec? The latest (2.2.2) tag is atleast 3 months old.

[ashtom]

I updated the podspec and also created the tag. Can you check if it now pulls the right version?

[vvasanth86]

@ashtom I was finally able to verify this just yesterday. The 2.2.3 version is green on the validation front. Closing this issue. Thanks!