-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking layout when using eminiarts/nova-tabs package #5
Comments
Hi, I have the same problem. Do you expect any fix for this? Thanks |
@stufarquhar @vbezruchkin Can you check if this release fix your problem ? https://github.com/codenco-dev/nova-grid-system/releases/tag/1.0.1 I don't know if the problem wasn't with breadcrumb for example. Thanks for your feedback |
@stufarquhar Have you got a feedback ? |
@thomasdominic I still have an issue here, I threw together a fix and sent a PR to nova-tabs, for the people interested: eminiarts/nova-tabs#97 |
@happyDemon Can you post a new issue on this repo and give me an example of resource ? I will try to look at this |
@thomasdominic the main difference with @vbezruchkin is that I used the The issue is that nova-tabs uses a custom component based on PanelItem and the container element didn't have I sent a PR to nova-tabs, in the meantime I tagged my repo so I could use it in my own projects in the meantime, @eminiarts doesn't seem to be very responsive when I look at all the open PRs. |
Okay :) |
@thomasdominic this is a killer package :D it's so weird nova doesn't support this out of the box |
@happyDemon hey thanks, don't hesitate to talk about it then :) |
This simply does not work when using eminiarts/nova-tabs in detail view. It does however work without the use of tabs thou.
see image.
The text was updated successfully, but these errors were encountered: