Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items not marked as collected on interactive map #31

Closed
FBroy opened this issue Mar 19, 2024 · 10 comments
Closed

Items not marked as collected on interactive map #31

FBroy opened this issue Mar 19, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@FBroy
Copy link

FBroy commented Mar 19, 2024

Some items are marked as not collected (red) on the interactive map, even though they are collected in-game. (even after saving and reloading the save in SOTFEdit)

A few items which I can already confirm are affected, are:

  • Laptop
  • Rebreather
  • Modern Axe
  • Flashlight Attachment
  • Ancient Armor

There may be more, but these are the ones I can see at first glance. If you need any more information, please let me know.

@codengine
Copy link
Owner

Could you attach one of the affected savegames so that I can have a look?

@FBroy
Copy link
Author

FBroy commented Mar 20, 2024

1606965940.zip

This is my most recent save I have.
This is a multiplayer save, in case this matters.

Small example:
I have the rebreather and collected everything in cave C (the shovel cave), but yet the rebreather is shown in red and the laptop and Flashlight attachment are still shown on the map when selecting to show only uncollected items.
image

@codengine
Copy link
Owner

I found the issue. Items that are currently equipped technically don't appear as "in inventory", so I'm going to have to find a workaround for that. Thanks for the report, I will call back when it is fixed!

@codengine codengine added the bug Something isn't working label Mar 20, 2024
@codengine codengine self-assigned this Mar 20, 2024
@codengine
Copy link
Owner

Fixed in this release: https://github.com/codengine/SOTFEdit/releases/tag/v0.12.3

@FBroy
Copy link
Author

FBroy commented Mar 21, 2024

Thanks for the quick patch! I'm currently testing everything and there still seem to be some edge cases.

  • If armor/clothing is equipped, it is shown as not collected on the map. (I tested this with unequipping the ancient armor in the save above, which removed it from the interactive map)
  • Laptops are still shown on the interactive map, even though these were already collected. In this save file, laptop 1 and laptop 2 were already collected.
  • Weapon attachments, such as the flashlight for the pistol are shown as not collected on the map when equipped on a weapon. When dismantling it from the pistol in the save above, it is removed from the map.

The rest is working as expected from the patch.

@codengine
Copy link
Owner

Dang... I was too quick and it was late :P Gonna have a second look.

@codengine codengine reopened this Mar 21, 2024
@codengine
Copy link
Owner

Please have a look at this build. It should resolve the issue with equipped cloths and weapon mods.
SOTFEdit-f5a98877.zip

@FBroy
Copy link
Author

FBroy commented Mar 25, 2024

After a quick initial test, the clothing and weapon attachments part seems to be fixed. However, now the clothing worn by Kelvin and Virginia is shown on the map as not collected. (Priest outfit for Kelvin and Camouflage outfit for Virginia in this save)

Also, the laptop part still persists. Not sure if you cannot change that at all, since you technically do not "take" the laptop, but just gain the information on it. I could open up another issue for this?

@codengine
Copy link
Owner

After a quick initial test, the clothing and weapon attachments part seems to be fixed. However, now the clothing worn by Kelvin and Virginia is shown on the map as not collected. (Priest outfit for Kelvin and Camouflage outfit for Virginia in this save)

Also, the laptop part still persists. Not sure if you cannot change that at all, since you technically do not "take" the laptop, but just gain the information on it. I could open up another issue for this?

The laptop is a World Object State I think which is listed here:
grafik

But I have no Savegame where every Laptop has been collected, so its kind of hard to research it.

For the outfit, "technically" you don't have it in your inventory. Also it is less of a outfit than more a "flag" for the followers - they do not really own the items. I'd leave it as it is for the follower items.

@FBroy
Copy link
Author

FBroy commented Mar 25, 2024

Then that solves everything related to this issue! Thanks for taking care of it!

@FBroy FBroy closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants