Migrate to Kotlin Multiplatform and kotlinx.serialization #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why this is not merged? |
|
We we're going to maintain a fork but our internal requirements changed and we delayed our need for the library. I'll try to schedule some free time to get that fork published to Maven Central. |
|
@codeniko any opposition to me making a new repo and artifact from this (I'd keep you in the copyright notice), or would you prefer this gets merged here? |
eygraber
force-pushed
the
kmp
branch
2 times, most recently
from
088ba2e
to
e1865df
Compare
|
@bestMechanic we're going to maintain our own fork separately for now at https://github.com/eygraber/JsonPathKt There's currently a snapshot at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I work with @eygraber and this fixes #7. Sorry for the size of the changeset; a lot had to happen at the same time to get it working.
The only breaking change here should be using kotlinx.serialization instead of Jackson; the API shouldn't change other than that. We think the API can be improved by just using extension functions but that's a conversation for another day.
In the tests, we removed some of the tests that were testing Jackson specific behavior.
This is the initial port plus changes to gradle for KMP. Future plans are:
We'll be using our own fork for now so there's pressure to get this merged.