CLDIDE-2631: Change behavior for perClick policy, add error notificat… #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,7 +125,7 @@ public void tryStartWorkspace() { | |||
| final WorkspaceConfigDto workspaceConfigDto = factory.getWorkspace(); | |||
|
|
|||
| if (workspaceConfigDto == null) { | |||
| //TODO handle this situation | |||
| notificationManager.showError("Workspace config is not defined"); | |||
There was a problem hiding this comment.
Should we add return here?
There was a problem hiding this comment.
yes it needed here, thank you
There was a problem hiding this comment.
Also move please message to localization contant
akorneta
force-pushed
the
CLDIDE-2631
branch
from
2fbcf5a
to
15bad0f
Compare
|
Ok |
akorneta
force-pushed
the
CLDIDE-2631
branch
2 times, most recently
from
053dea5
to
cc70bfe
Compare
akorneta
force-pushed
the
CLDIDE-2631
branch
from
ae52f27
to
55a7878
Compare
|
If workspace already exists You should add counter to the name |
| @@ -470,6 +470,9 @@ | |||
| @Key("workspace.start.failed") | |||
| String workspaceStartFailed(String workspaceName); | |||
|
|
|||
| @Key("workspace.start.failed") | |||
There was a problem hiding this comment.
Change please key for this property. I think It'll broke gwt compiling
akorneta
force-pushed
the
CLDIDE-2631
branch
2 times, most recently
from
35fcaf3
to
de23be3
Compare
| */ | ||
| private Promise<UsersWorkspaceDto> getWorkspaceByConditionOrCreateNew(final WorkspaceConfigDto workspaceConfigDto, | ||
| final Function<UsersWorkspaceDto, Boolean> condition) { | ||
| final Function<UsersWorkspaceDto, Boolean> condition, | ||
| final boolean generateName) { |
There was a problem hiding this comment.
I think it would be better to name this parameter something like useExists or createNewWorkspace
akorneta
force-pushed
the
CLDIDE-2631
branch
from
de23be3
to
748c99f
Compare
|
Other OK for me |
1 similar comment
|
Other OK for me |
akorneta
force-pushed
the
CLDIDE-2631
branch
from
748c99f
to
1895ad5
Compare
akorneta
added a commit
that referenced
this pull request
Nov 27, 2015
CLDIDE-2631: Change behavior for perClick policy, add error notificat…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions