Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve using of async requests #498

Merged
merged 3 commits into from
Dec 9, 2015
Merged

Improve using of async requests #498

merged 3 commits into from
Dec 9, 2015

Conversation

azatsarynnyy
Copy link
Contributor

  • Added ability to get result of AsyncRequest via Promise.
  • Deprecated PromiseHelper since AsyncRequest#send() returns Promise with request result.
  • Refactored AsyncRequest class to make it more readable.
  • Reworked MachineServiceClientImpl in order to get result of asynchronous requests via Promise. Avoid using deprecated PromiseHelper.
  • Removed obsolete methods from MachineServiceClient.

@vparfonov
Copy link
Contributor

ok, @sleshchenko ?

@sleshchenko
Copy link
Contributor

LGTM

azatsarynnyy added a commit that referenced this pull request Dec 9, 2015
@azatsarynnyy
Merge pull request #498 from codenvy/async_request_improvements
04b1965 
Improve using of async requests
@azatsarynnyy azatsarynnyy merged commit 04b1965 into 4.0 Dec 9, 2015
@azatsarynnyy azatsarynnyy deleted the async_request_improvements branch December 9, 2015 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@azatsarynnyy @vparfonov @sleshchenko