IDEX-3853 Add requirements for the console for displaying output. Remove unused code #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @author Roman Nikitenko | ||
| */ | ||
| public interface OutputConsole extends Presenter { |
There was a problem hiding this comment.
It's a part of IDE API. So it has to be placed into che-core-ide-api module in order to avoid extensions depend on che-core-ide-app.
@vparfonov WDYT?
There was a problem hiding this comment.
+1 for moving to che-core-ide-api
RomanNikitenko
force-pushed
the
IDEX-3853
branch
from
3c5da69
to
2573f0a
Compare
|
ok |
RomanNikitenko
force-pushed
the
IDEX-3853
branch
from
2573f0a
to
f9fb906
Compare
RomanNikitenko
added a commit
that referenced
this pull request
Jan 16, 2016
IDEX-3853 Add requirements for the console for displaying output. Remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add requirements for the console for displaying output.
Remove unused code