IDEX-3744: disable docker machine state change detection #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ок |
|
do we need // FIXME in the commented lines ? |
|
Problem is that because of docker implementation of oom events we can't fix it without implementing oom detector on system level. I'm going to create issue in docker. |
garagatyi
force-pushed
the
IDEX-3744-2
branch
2 times, most recently
from
91f347e
to
a7f8454
Compare
garagatyi
pushed a commit
that referenced
this pull request
Dec 4, 2015
IDEX-3744: disable docker machine state change detection
Comment usage of container state change because it has bug. Exec's OOM is treated as OOM of container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment usage of container state change because it has bug.
Exec's OOM is treated as OOM of container.