IDEX-4047 - Add ability to skip checks to startup script #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 11, 2016 12:33
|
I don't like name of new options. It is not obvious what they do from their names. And options with the same names and different parameters are used for different purposes. It is bad practice. |
|
I am not aware of this being bad practice. I think the syntax is ok as the docs make it clear. I do not want to have long names, and anticipate adding a variety of skip:{} parameters over time. |
|
I commented in jira |
TylerJewell
pushed a commit
that referenced
this pull request
Jan 14, 2016
IDEX-4047 - Add ability to skip checks to startup script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added --skip:client to skip printing out the client connection information.
Added --skip:uid to skip docker UID=1000 check on startup.