Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constants in UpdateClient.class.php #39

Closed
xxsimoxx opened this issue Feb 19, 2020 · 1 comment
Closed

Constants in UpdateClient.class.php #39

xxsimoxx opened this issue Feb 19, 2020 · 1 comment
Assignees
@johnalarcon
Labels
Status: Completed This item has been implemented or otherwise addressed. Type: Defect This item is an error or other behavior that negatively impacts code execution.
Milestone
2.0.0

Comments

@xxsimoxx
Copy link
Owner

Description

Constants will be undefined when the class is used alone.
PLUGIN_PREFIX is used here and here

Additional Context

It is just related to milestone 2.0.0 branch.
@johnalarcon johnalarcon added Status: Completed This item has been implemented or otherwise addressed. Type: Defect This item is an error or other behavior that negatively impacts code execution. labels Feb 19, 2020
@johnalarcon johnalarcon added this to the 2.0.0 milestone Feb 19, 2020
johnalarcon added a commit that referenced this issue Feb 19, 2020
@johnalarcon
Remove PLUGIN_PREFIX constant
6032cb6 
This constant is out of scope. Closes #39.
@johnalarcon
Copy link
Collaborator

Fixed on the milestone branch. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnalarcon johnalarcon

Labels
Status: Completed This item has been implemented or otherwise addressed. Type: Defect This item is an error or other behavior that negatively impacts code execution.
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@johnalarcon @xxsimoxx