Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display editable icon on hover #174

Closed
tobiasschutter opened this issue Apr 9, 2015 · 1 comment
Closed

Only display editable icon on hover #174

tobiasschutter opened this issue Apr 9, 2015 · 1 comment

Comments

@tobiasschutter
Copy link
Member

Currently when you have the inline-edit "on", all icons will be visible. Maybe it would be better if the icons stay hidden untill you hove the actual column value. (feedback please)

To have a look at the result, use this code:

function my_only_display_editable_actions_on_hover() { ?>
    <style type="text/css">
        .cacie-editable-container .cacie-cell-actions { display: none !important; }
        .cacie-editable-container:hover .cacie-cell-actions { display: block !important; }
    </style> <?php
}
add_action( 'cac/admin_head', 'my_only_display_editable_actions_on_hover' );
@tobiasschutter tobiasschutter added this to the Requested features milestone Apr 9, 2015
@engelen
Copy link
Contributor

engelen commented Apr 9, 2015

We've considered and implemented this approach when we first started developing inline editing. Even though it does affect the list table less and ensures a better overview, it's quite difficult to see which columns are editable. A solution to this would be to add an icon or another type of mark in the column header, showing that the column is editable. However, there are two problems with this. Firstly, without fixed table headers, scrolling down on longer lists makes the column headers invisible, and thus hides the information about editability. Secondly, there are columns for which not all items are editable. For example, an entire post may not be editable based on permissions, and certain types of WooCommerce columns also have editability checks per post.

All-in-all, I believe our current approach is quite solid.

@DGStefan DGStefan removed this from the Requested features milestone Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants