Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater Field and The Flexible Content Field add-ons can give an error in ACF version 4 #242

Closed
davidmosterd opened this issue Aug 14, 2015 · 3 comments

Comments

@davidmosterd
Copy link
Member

This was reported on the forum: https://www.admincolumns.com/forums/topic/fatal-error-using-acf-date-picker/

The function acf_get_value() is called but not supported in ACF version 4 in combination with the repeater field or the flexible content field.

We are currently looking into finding the best replacement that works for V4 and V5 (ACF PRO).

@davidmosterd
Copy link
Member Author

acf_get_value seems to be deducted from acf_field_functions::load_value in V4. I will investigate a wrapper function that takes V4 and V5 in consideration.

@tobiasschutter tobiasschutter modified the milestones: 3.7, 3.6 Oct 9, 2015
@tobiasschutter tobiasschutter modified the milestones: 3.8, 3.7 Jan 14, 2016
@tobiasschutter tobiasschutter modified the milestones: 3.8.1, 3.8 Mar 16, 2016
@davidmosterd davidmosterd self-assigned this Mar 25, 2016
@davidmosterd
Copy link
Member Author

I have proposed a fix in a pull request; the idea is to fall back to the get_field_object method when acf_get_values() is not available. This way it should only impact ACF4 users in a positive way and have no effect on ACF5 (pro) users

@DGStefan
Copy link
Member

Already fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants