Cannot 'Open Folder...' on code-server Welcome Page

[JammSpread]

OS/Web Information

• Web Browser: Chrome
• Local OS: Chrome OS
• Remote OS: Debian GNU/Linux
• Remote Architecture: amd64
• code-server --version: 3.9.1 + 3.9.2

Steps to Reproduce

1. Load up a fresh setup of code-server without specifying a folder or with --ignore-last-opened on Linux.
   (You could also use the Help: Welcome command.)
2. Click Open Folder under the Start Section.

Expected

It uses the open folder command specific to your remote OS and you can select a folder.

Actual

Witness nothing happens as after you click the link as the command it references may not even exist on your version of VSCode.

Screenshot

Notes

Has occurred on multiple Linux machines, this is my third remote machine I'm using to report it.

This issue can be reproduced in VS Code: Unknown

Seems to originate from this line. This might occur due to the 'mac-only' class version being used wrongly.

[jsjoeio]

Thanks for opening this issue and adding all the details @JammSpread ! Yeah that's weird they have the mac-only class there. I'm guessing you're right. We'll look into this!

[oxy]

Tested on Fedora 34 with the official code-server rpm right now, using either --ignore-last-opened or Help: Welcome and then clicking Open Folder worked on my environment, on both Chromium and Firefox.

Could this be Chrome OS specific?

[oxy]

@JammSpread could you view the page with inspect element and find out which li element is displayed - the macOS one or the Linux/Windows one (or is something else being displayed)?

[JammSpread]

Sure, I'll try that soon. If it did work for you it could be that it doesn't resolve Chrome OS to be either.

[JammSpread]

I'm very sorry for the late reply.
After trying and inspecting on the local OS (Chrome OS) and Chrome/Firefox on Debian, I've come to a similar conclusion.

Could this be Chrome OS specific?

The assumption seems to be correct.
It seems that Chrome OS is falsely detected as macOS and thus uses its platform-specific command.
This doesn't occur, in contrast, on standard Linux environments.

[JammSpread]

This might be just a speculation but shouldn't it use the remote OS' command and not the detected local OS'?

[jsjoeio]

Do we know if this is an upstream issue or specific to code-server?

Can it be reproduced on Codespaces?

[JammSpread]

I haven't been able to access the Codespaces Beta however this is reproducible in Gitpod.
It seems it may be upstream and an issue with handling Chrome OS.

[jsjoeio]

Ah gotcha. Well that's a good sign then!

Shoot, I wish I had access to Chrome OS. Or if there were a way for me to lend you access to my Codespaces Beta. Then I could try and reproduce and we could file upstream.

[JammSpread]

You might be able to reproduce it by using a similar or the same user agent I have.

Mozilla/5.0 (X11; CrOS x86_64 13729.56.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.95 Safari/537.36

You might be able to make use of this through a browser extension or by manually modifying your HTTP(S) requests.

[jsjoeio]

Ooo didn't think about that. That could work! Okay, great. I think we have what we need to investigate this further. Thanks a ton for your work @JammSpread! 🎉

[jsjoeio]

I was able to reproduce locally in #3427