-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 14 (macOS 11 / iOS 14) no longer able to load vscode interface #6805
Comments
The problem seems likely to be upstream in VS Code; I recommend testing vscode.dev and GitHub Codespaces and if it reproduces there then report in https://github.com/microsoft/vscode If it does not reproduce in either of those places though, we will have to see if code-server is doing something different here. I am not sure what it could be though. |
confirmed it is upstream bug and created new issue under microsoft/vscode#213143 tested code-server@4.17.1 with my Safari and everything is fine. Can I keep this issue open for tracing purposes? |
Awesome, thank you!
Yup, that sounds good to me. |
is it possible to build latest code-server with older vscode? Is there any instructions for doing this? |
After cloning code-server you can check out whatever branch you want of the VS Code sub-module. However, it will be unlikely that the patch files will apply to older versions, so you may have to do a lot of conflict resolution. |
If you want to try this, the instructions would be the same as updating VS Code, just you are downgrading the submodule instead of upgrading: https://github.com/coder/code-server/blob/main/docs/CONTRIBUTING.md#version-updates-to-code |
is there any way to prevent rebuilding? This takes over 40 minutes per build
|
VS Code does not seem to support incremental building, at least not last time I checked. |
Is there an existing issue for this?
OS/Web Information
code-server --version
: 4.89.1 effc6e9 with Code 1.89.1Steps to Reproduce
npm i code-server --install-from-source -g
, this shall build all required modules natively~/node_modules/out/node/entry.js --bind-addr 0.0.0.0:8080
localhost:8080
in SafariExpected
The login page and VSCode page should be successfully loaded
Actual
While opening with Google Chrome, everything is fine.
While opening with Safari 14, VSCode page is completely white, error logs printed to remote console.
Logs
Screenshot/Video
Opening with Google Chrome is fine:
![image](https://private-user-images.githubusercontent.com/31795847/332334495-94592684-0f09-4672-93e3-e5d4ecc59a65.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1Mjg4NzcsIm5iZiI6MTcxODUyODU3NywicGF0aCI6Ii8zMTc5NTg0Ny8zMzIzMzQ0OTUtOTQ1OTI2ODQtMGYwOS00NjcyLTkzZTMtZTVkNGVjYzU5YTY1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDA5MDI1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFmZGZlMTRhZWM5NDg0OGNkNjg2OGM0YTUxNjRmYjlmNzlkMzQ1YWRmZTYwYjc3YzZlYmE4NWMwYzEzZDExMTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qHg5ouvsFaDDg_D1TtF92LHrrK0sfq8CwYluC1JR62A)
Does this bug reproduce in native VS Code?
I did not test native VS Code
Does this bug reproduce in GitHub Codespaces?
I did not test GitHub Codespaces
Are you accessing code-server over a secure context?
Notes
No response
The text was updated successfully, but these errors were encountered: