Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen mode #73

Closed
zanhk opened this issue Mar 7, 2019 · 6 comments
Closed

Full screen mode #73

zanhk opened this issue Mar 7, 2019 · 6 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@zanhk
Copy link

zanhk commented Mar 7, 2019

In the top-right corner keep just a button to toggle fullscreen mode

@kylecarbs kylecarbs added the enhancement Some improvement that isn't a feature label Mar 7, 2019
@lucacasonato
Copy link
Contributor

Use the already existing window maximize button. We should also make the X close the tab while we are at it.

@zanhk
Copy link
Author

zanhk commented Apr 17, 2019

What? the maximize button in windows it's not for fullscreen mode, in the post I also wrote to Keep just 1 button to toggle the fullscreen mode (F11), others are useless

@kylecarbs
Copy link
Member

Feels kinda weird to add this. I believe the fullscreen command doesn't work atm. Might work to just fix that.

@code-asher
Copy link
Member

We decided to remove the buttons in the top-right corner. You can still use F11 and on Chrome you can also use the command palette.

@maxfi
Copy link

maxfi commented May 4, 2019

@kylecarbs I couldn't find an issue for fullscreen not working. When pressing F11 the following error occurs:

ERR Document not active: TypeError: Document not active
    at t.setFullScreen (http://127.0.0.1:10162/ide.main.92c1f4.js:38:75836)
    at e.toggleFullScreen (http://127.0.0.1:10162/ide.main.92c1f4.js:60:1645872)
    at t.toggleFullScreen (http://127.0.0.1:10162/ide.main.92c1f4.js:60:6355817)
    at t.run (http://127.0.0.1:10162/ide.main.92c1f4.js:60:1591193)
    at http://127.0.0.1:10162/ide.main.92c1f4.js:23:101901

@cnfatal
Copy link

cnfatal commented Feb 20, 2022

Command Palette >:View: Toggle Full Screen. works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

6 participants