Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to upstream kaniko #198

Closed
johnstcn opened this issue May 20, 2024 · 4 comments
Closed

migrate to upstream kaniko #198

johnstcn opened this issue May 20, 2024 · 4 comments
Labels
enhancement New feature or request spike Investigation to prove feasibility or validate an idea

Comments

@johnstcn
Copy link
Member

johnstcn commented May 20, 2024

We are currently on a fork of github.com/GoogleContainerTools/kaniko (github.com/coder/kaniko).

Our fork includes some extra changes that are not included in upstream Kaniko:

@coder-labeler coder-labeler bot added enhancement New feature or request spike Investigation to prove feasibility or validate an idea labels May 20, 2024
@mafredri
Copy link
Member

mafredri commented May 22, 2024

@johnstcn with 43b5b37, is the only remaining issue the output capture?

Would it be feasible to run Kaniko as an external program and capture the output that way? Or are we tweaking the behavior in a way that can't be adjusted via env/flags?

I think it's still valuable if we can embed Kaniko, but that's quite easily achieved via:

import (
	"os"

	"github.com/GoogleContainerTools/kaniko/cmd/executor/cmd"
)

func main() {
	if err := cmd.RootCmd.Execute(); err != nil {
		os.Exit(1)
	}
}

The benefit of this would be that we can support both modes of operation, external or embedded Kaniko.

@johnstcn
Copy link
Member Author

I believe that's the only reason. I think the change you propose is possible as a refactor.

@mafredri
Copy link
Member

Alright, thanks for confirming. OTOH, with #124 we'll be still need to maintain a fork. 😅

@johnstcn
Copy link
Member Author

We'll need to stay on our own fork for the foreseeable future.

@johnstcn johnstcn closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spike Investigation to prove feasibility or validate an idea
Projects
None yet
Development

No branches or pull requests

2 participants