Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document breaking changes #55

Closed
matifali opened this issue Sep 27, 2023 · 2 comments
Closed

Document breaking changes #55

matifali opened this issue Sep 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@matifali
Copy link
Contributor

We should document the behavior when we update a module in such a way that it breaks existing templates. Examples are.

  1. Adding/removing/renaming required variables.
  2. Updating default values of any variable.
  3. etc

Suggestions

  • use versioning, so that if someone uses
module "jfrog" {
    source                   = "https://registry.coder.com/modules/jfrog"
	version                  = "1.0"
    agent_id                 = coder_agent.main.id
    jfrog_url                = "https://YYY.jfrog.io"
    ...
}
  • more ideas

cc: @bpmct, @kylecarbs

@matifali matifali added the enhancement New feature or request label Sep 27, 2023
@bpmct
Copy link
Member

bpmct commented Oct 1, 2023

I'm a huge fan of versioning our modules so that our users always have to opt-in to a new module behavior. How is this possible if our modules are hosted in GitHub, and not a registry? Perhaps we will need to https://registry.coder.com a more mature registry.

Alternatively, we could reference source being a specific commit SHA or tag and have separate releases for modules.

Main reasoning being: We should, of course document breaking changes, but I think a versioning system is far more important at first. Then, each module could perhaps have a changelog.

@matifali
Copy link
Contributor Author

Closer in #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants