Skip to content
This repository has been archived by the owner on Jan 17, 2021. It is now read-only.

Option to upload code-server binary #73

Closed
kjetilhp opened this issue Apr 29, 2019 · 10 comments · Fixed by #136
Closed

Option to upload code-server binary #73

kjetilhp opened this issue Apr 29, 2019 · 10 comments · Fixed by #136

Comments

@kjetilhp
Copy link

Add option to upload code-server binary when there is no internet connection on the remote host.

@sreya
Copy link
Collaborator

sreya commented Apr 30, 2019

This is interesting, I imagine you would need this for cases where you have your entire machine firewalled except for the ssh port?

@kjetilhp
Copy link
Author

kjetilhp commented Apr 30, 2019 via email

@teddy-codes
Copy link
Contributor

scp would work for this. Using a ping to coder.com or something similar would be fine to check if egress traffic is allowed, then using the "client" (for lack of a better term) to download the code-server bin and scp it.

@deansheather
Copy link
Member

I think people using remote servers without a direct internet connection is a pretty limited usecase. Maybe we could add a --no-update flag that prevents the update check, so you could copy code-server to the machine yourself beforehand.

@kjetilhp
Copy link
Author

I think not, a lot of big organisations and certainly government institutions have a lot of in-house servers that never are allowed touching the internet. But a script with scp and no-update would do.

@magic-lantern
Copy link

I need this feature as well. In response to @deansheather comment about limited usefulness: I've worked in the healthcare industry for over 12 years. Security is a key part of the software development lifecycle and IT portion of healthcare. I've worked for a large non-profit health care organization and an academic medical institution, and having open access to the internet is actually quite rare for any system with health care data. It's very common in health care to allow inbound connections such as SSH/RDP, but prevent outbound Internet access to reduce the likelihood of data exfiltration.

The other common case for security is that authentication at a web proxy is required to gain some outbound Internet access - which as previously mentioned is feature request #74

@deansheather
Copy link
Member

Seems like I was wrong, maybe this would be a good idea after all.

@xgdgsc
Copy link

xgdgsc commented Jul 18, 2019

I also find this useful for my use cases in finance industry.

@deansheather
Copy link
Member

Made a PR that adds a --code-server-path flag. You can specify a path to a local code-server binary and it will be uploaded instead of the update script being executed.

@deansheather
Copy link
Member

The flag has been renamed to --upload-code-server, and has been merged into master. It should work with code-server v2 previews as well! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants