Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Including sample app #2

Closed
dariobanfi opened this issue Nov 2, 2014 · 6 comments
Closed

[Suggestion] Including sample app #2

dariobanfi opened this issue Nov 2, 2014 · 6 comments

Comments

@dariobanfi
Copy link

Hi, thanks for this awesome patch in the first place.

Wouldn't it be good to include a sample example activity with 2 players working at the same time?

I tried to implement the patches in this sample vlc example app

https://bitbucket.org/edwardcw/libvlc-android-sample

But I get both videos blinking at the same time during the playback (I'll keep working on this and post the sample myself if I can fix it)

@ghost ghost mentioned this issue Nov 1, 2014
@dariobanfi
Copy link
Author

I created a sample project, at the moment it works (only tested with 2)
You can use it to test the new versions of the patch.

https://github.com/Ambigioz/multiplevlc

I had to add a callback(int, Bundle, LibVLC) method to EventHandler since it was missing.
Some work needs to be done with the Events of vlc, since they often cause native crashes.

@coderReview
Copy link
Owner

Hi, thanks. I will upload later today mine modified EventHandler class.
What are your experience ? Works ok or many crashs happens ?

@coderReview
Copy link
Owner

Updated patch with modified java source code.

@dariobanfi
Copy link
Author

There is still problem with callback in EventHandler, it crashes saying that a method with signature callback(int, Bundle) is missing.. I think there's still some native call using the old one.

@coderReview
Copy link
Owner

Yes, I've fixed that already but forgot to post the update. Will do it as soon as I can.

@coderReview
Copy link
Owner

Sorry for taking so long. Commit a new fix. Try that out. I've also made some improvements with the native crash handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants