Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve "try" and "guard" tests #3

Closed
wants to merge 3 commits into from
Closed

Solve "try" and "guard" tests #3

wants to merge 3 commits into from

Conversation

Bellisario
Copy link
Contributor

This solves "try" and "guard" compile test by "forcing" both codes to be a string.

All this is very strage because running the same tests doing a sort of debug printing (on the console), code and value types will result the same to eye and also by comparing them with VS Code built-in feature...
The strangest thing is also this code test (in "production" mode) here: the result is both strings are equal, but that's not so by running tests.
All this should be investigated more, currently project tests could not be so reliable.

@coderaiser
Copy link
Owner

That's strange because actions are passing, and text is strings, already:

const fromData = readFileSync(from, 'utf8');
const toData = readFileSync(to, 'utf8');

Where do you have the problem?

@Bellisario Bellisario marked this pull request as draft June 23, 2022 17:31
@Bellisario
Copy link
Contributor Author

I made a mistake, I changed my pull instead of creating a new repository, I liked to test on a "clear" Windows machine if this is actually my problem or other Windows have the same issue...

@Bellisario
Copy link
Contributor Author

@coderaiser here is the same error I have on my computer on GitHub Actions running in Windows (instead of Ubuntu): https://github.com/Bellisario/goldstein-test/runs/7044057703?check_suite_focus=true

I'm trying to understand what's wrong but seems this isn't a problem of Windows CRLF...
My changes (at least on my computer) seems to solve the issue, I'll study more to see what's wrong...

@Bellisario Bellisario closed this Jun 25, 2022
@Bellisario
Copy link
Contributor Author

Solved using Gitpod instead of Windows environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants