Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecars from template pods #2

Open
coderanger opened this issue May 21, 2021 · 0 comments
Open

Sidecars from template pods #2

coderanger opened this issue May 21, 2021 · 0 comments

Comments

@coderanger
Copy link
Owner

Right now only the template container is carried over to the migration job. While not all sidecars should be copied, it would be good if the default was to copy all of them as well as allowing some kind of include/exclude list based on container names.

Proposed API:

SidecarInclude *[]string `json:"sidecarInclude,omitempty"`
SidecarExclude *[]string `json:"sidecarExclude,omitempty"`

If neither is specified, all sidecars (i.e. all containers other than the template container) are copied. Include means "only these", exclude is "all but these" (with neither copying the template container since that's already handled). Specifying both should be a validation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant